fixes #1276: Add streaming support to export JSON and GraphML #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneedham
reviewed
Nov 11, 2019
| ExportFileManager cypherFileManager = FileManagerFactory.createFileManager(fileName, false, exportConfig.streamStatements()); | ||
| final PrintWriter graphMl = cypherFileManager.getPrintWriter("graphml"); | ||
| if (exportConfig.streamStatements()) { | ||
| long timeout = exportConfig.getTimeoutSeconds(); |
There was a problem hiding this comment.
Can we reuse the streaming exporter code across all the export formats (CSV, JSON, GraphML) rather than having the same code multiple times?
I think the only thing that changes is the line that does the write/dump?
mneedham
reviewed
Nov 11, 2019
| printWriter.flush(); | ||
| printWriter.close(); | ||
| return reporter.stream(); | ||
| ExportFileManager cypherFileManager = FileManagerFactory.createFileManager(fileName, false, exportConfig.streamStatements()); |
There was a problem hiding this comment.
The last parameter into createFileManager is unused - can probably delete that
|
@mneedham I updated the PR. |
sarmbruster
pushed a commit
that referenced
this pull request
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1276
Add streaming support to export JSON and GraphML
Proposed Changes (Mandatory)
A brief list of proposed changes in order to fix the issue: