Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "tx hash" log #854

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Remove "tx hash" log #854

merged 1 commit into from
Jun 24, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Jun 24, 2019

Currently travis is very dirty with these logs.

https://travis-ci.org/neo-project/neo/jobs/549577636

@codecov-io
Copy link

Codecov Report

Merging #854 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #854   +/-   ##
=======================================
  Coverage   43.57%   43.57%           
=======================================
  Files         177      177           
  Lines       12547    12547           
=======================================
  Hits         5467     5467           
  Misses       7080     7080

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90fa9af...1f2496e. Read the comment docs.

@shargon shargon changed the title Remove log from tx hash Remove "tx hash" log Jun 24, 2019
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't agree more.. this bothers me A LOT!

@shargon shargon merged commit 31bee40 into neo-project:master Jun 24, 2019
@shargon shargon deleted the small-fix branch June 24, 2019 13:54
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants