count consensus time when primary calculate wait span #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests for All Mailboxes (Neo 2.x) (#821)
|
Don't improve 2.x any more. Let's work on 3.0. |
|
ok. I will close this and reopen on 3.0. |
|
@kickseason, in addition, base time on prepreq should be carefull designed, because the flow of states is also guided by timeouts, protecting the liveness from faulty primaries and other types of problems. |
|
For 2x, its better to focus on bugfixes only perhaps, as Erik said. Small things on p2p could also decrease these times. |
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* Update private-chain3.md * Update private-chain3.md * update
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* Follow up neo-project#826 * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should count consensus time in when calculate wait span in order to ensure block time.
@shargon @igormcoelho @vncoelho @erikzhang
I modify my pr. Never give up.