-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin LevelDB] First step of 3414 - Comments and style #3575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing proper commit description. Still mixing comments and code changes (including new methods) into a single commit.
/// <summary> | ||
/// Moves to the previous entry in the source. | ||
/// After this call, Valid() is true if the iterator was not positioned at the first entry in source. | ||
/// REQUIRES: Valid() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it? Can I go back to "c" in "a b c" after three "Next" calls and !Valid()
(ended) iterator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comemnt is from the @cschuchardt88 pr, i did not really check it, but anyway, if its not yet proper, i will remove it until the last minute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just suggesting here, I don't know the real behavior, but we want comments to be correct wrt these details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a useful comment after all, the only question is Valid()
requirement, please return it (maybe except for Valid()
line if we don't know for sure). I'm also not sure Valid()
requirement is appropriate for Next()
(suppose Prev()
at a
of a b c
and Next()
then). Needs to be checked.
Description
Credits goes to @cschuchardt88. This is the first task of merging pr-3414 as we discussed. No functional change, just comment and style update. Can be safely merged into master.
Fixes # #3414
Type of change
Test Configuration:
Checklist: