-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Props paths for *.csproj
builds
#3320
Conversation
What is the problem with the original code? |
If you don't use a solution file. It will have wrong pathing.
Example (linux)
|
May be post a few pic of before this pr and after this pr. |
Same issue as that PR #3306 fixes |
But this doesn't work before, I remember |
msbuild reads upwares to the working directory for This PR fixes the problems when using a Didn't work before, because not enough |
Users like me are the same as devcontainer, everything I have is docker base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This previously failed, but it works, is good for me
This works for me. |
…eo-project#3352) This reverts commit 2d0395f.
Change Log
$(SolutionDir)
to../../
NOTE: for
github
actions and building from*.csproj
files.Fixes #3345
Type of change
How Has This Been Tested?
Locally
Checklist: