Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Props paths for *.csproj builds #3320

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jun 11, 2024

Change Log

  • Changed from $(SolutionDir) to ../../

NOTE: for github actions and building from *.csproj files.

Fixes #3345

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y
Copy link
Contributor

Jim8y commented Jun 11, 2024

What is the problem with the original code?

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jun 11, 2024

If you don't use a solution file. It will have wrong pathing.

$(SolutionDir) will be empty so path will be \.neo\neo.png

Example (linux)

dotnet pack ./srv/neo/neo.csproj

@Jim8y
Copy link
Contributor

Jim8y commented Jun 11, 2024

If you don't use a solution file. It will have wrong pathing.

Example (linux)

dotnet pack ./srv/neo/neo.csproj

May be post a few pic of before this pr and after this pr.

@Jim8y Jim8y requested a review from a team June 11, 2024 02:47
@cschuchardt88
Copy link
Member Author

Same issue as that PR #3306 fixes

@shargon
Copy link
Member

shargon commented Jun 11, 2024

But this doesn't work before, I remember

@vncoelho vncoelho mentioned this pull request Jun 11, 2024
@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jun 16, 2024

But this doesn't work before, I remember

msbuild reads upwares to the working directory for *.props, In solution file or not.

This PR fixes the problems when using a *.csproj file, NOT a solution file (*.sln) for github workflows and linux/vscode users like @vncoelho

Didn't work before, because not enough ../../../../../ or too many last time.

@vncoelho
Copy link
Member

But this doesn't work before, I remember

msbuild reads upwares to the working directory for *.props, In solution file or not.

This PR fixes the problems when using a *.csproj file, NOT a solution file (*.sln) for github workflows and linux/vscode users like @vncoelho

Didn't work before, because not enough ../../../../../ or too many last time.

Users like me are the same as devcontainer, everything I have is docker base.

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This previously failed, but it works, is good for me

@superboyiii
Copy link
Member

This works for me.

@NGDAdmin NGDAdmin merged commit 2bd2a45 into neo-project:master Jun 18, 2024
8 checks passed
vncoelho added a commit that referenced this pull request Jun 18, 2024
cschuchardt88 added a commit that referenced this pull request Jun 21, 2024
@cschuchardt88 cschuchardt88 deleted the fix/props-files branch June 24, 2024 05:40
NGDAdmin pushed a commit that referenced this pull request Jun 26, 2024
cschuchardt88 added a commit to cschuchardt88/neo that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong debug/release path of plugins
6 participants