plugins: remove expressions that are always true (#3393)

* this expression is always true * Improve --------- Co-authored-by: Shargon <[email protected]>
neo-project · Jul 3, 2024 · 96c9e77 · 96c9e77
1 parent 5f66404
commit 96c9e77
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/Plugins/ApplicationLogs/LogReader.cs b/src/Plugins/ApplicationLogs/LogReader.cs
@@ -143,12 +143,11 @@ private void OnGetBlockCommand(string blockHashOrIndex, string eventName = null)
                 _neostore.GetBlockLog(blockhash, TriggerType.PostPersist) :
                 _neostore.GetBlockLog(blockhash, TriggerType.PostPersist, eventName);
 
-            if (blockOnPersist == null && blockOnPersist == null)
+            if (blockOnPersist == null)
                 ConsoleHelper.Error($"No logs.");
-            if (blockOnPersist != null)
-                PrintExecutionToConsole(blockOnPersist);
-            if (blockPostPersist != null)
+            else
             {
+                PrintExecutionToConsole(blockOnPersist);
                 ConsoleHelper.Info("--------------------------------");
                 PrintExecutionToConsole(blockPostPersist);
             }

diff --git a/src/Plugins/OracleService/OracleService.cs b/src/Plugins/OracleService/OracleService.cs
@@ -532,7 +532,7 @@ private bool CheckTxSign(DataCache snapshot, Transaction tx, ConcurrentDictionar
             }
             ECPoint[] oraclesNodes = NativeContract.RoleManagement.GetDesignatedByRole(snapshot, Role.Oracle, height);
             int neededThreshold = oraclesNodes.Length - (oraclesNodes.Length - 1) / 3;
-            if (OracleSigns.Count >= neededThreshold && tx != null)
+            if (OracleSigns.Count >= neededThreshold)
             {
                 var contract = Contract.CreateMultiSigContract(neededThreshold, oraclesNodes);
                 ScriptBuilder sb = new ScriptBuilder();