This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
3.0.0-CI00044 #357
Merged
3.0.0-CI00044 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A historical achievement. Congratulations, Erik. |
shargon
reviewed
May 16, 2019
shargon
reviewed
May 16, 2019
| @@ -815,19 +730,8 @@ private bool OnListAddressCommand(string[] args) | |||
| private bool OnListAssetCommand(string[] args) | |||
| { | |||
| if (NoWallet()) return true; | |||
| foreach (var item in Program.Wallet.GetCoins().Where(p => !p.State.HasFlag(CoinState.Spent)).GroupBy(p => p.Output.AssetId, (k, g) => new | |||
| { | |||
There was a problem hiding this comment.
we will add this in the future?
There was a problem hiding this comment.
Did not find a good way to list all NEP-5 assets.
There was a problem hiding this comment.
Maybe we should iterate all contracts, and try to find it according to NEP10?
There was a problem hiding this comment.
Or maybe we should add a new command for wallets, add nep5 token, and only look if you append it before?
There was a problem hiding this comment.
I will build this function into Wallet.
|
When neo-project/neo#753 will be integrated, i can approve it |
|
@shargon It will be. We are going to test it before approving. |
vncoelho
reviewed
May 20, 2019
There was a problem hiding this comment.
Settings.cs(69,16): error CS0246: The type or namespace name 'Fixed8' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/Coins.cs(26,16): error CS0246: The type or namespace name 'Fixed8' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/Coins.cs(47,16): error CS0246: The type or namespace name 'Fixed8' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/Coins.cs(55,16): error CS0246: The type or namespace name 'ClaimTransaction' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/Coins.cs(91,16): error CS0246: The type or namespace name 'ClaimTransaction' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/MainService.cs(40,17): error CS0246: The type or namespace name 'WalletIndexer' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/MainService.cs(256,16): error CS0246: The type or namespace name 'InvocationTransaction' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/MainService.cs(284,68): error CS0246: The type or namespace name 'InvocationTransaction' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/MainService.cs(284,16): error CS0246: The type or namespace name 'InvocationTransaction' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/MainService.cs(304,35): error CS0246: The type or namespace name 'InvocationTransaction' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/MainService.cs(1366,42): error CS0246: The type or namespace name 'WalletIndexer' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
Shell/MainService.cs(35,17): error CS0246: The type or namespace name 'WalletIndexer' could not be found (are you missing a using directive or an assembly reference?) [/opt/neoCli/neo-cli/neo-cli.csproj]
shargon
reviewed
May 22, 2019
neo-cli/neo-cli.csproj
Outdated
| @@ -3,7 +3,7 @@ | |||
| <PropertyGroup> | |||
| <Copyright>2016-2019 The Neo Project</Copyright> | |||
| <AssemblyTitle>Neo.CLI</AssemblyTitle> | |||
| <Version>3.0.0-preview1</Version> | |||
| <Version>2.10.1</Version> | |||
There was a problem hiding this comment.
After we are ready for release the preview, I will increase the version number.
shargon
approved these changes
May 22, 2019
|
Maybe we need to solve the test error before merge |
|
The error is because of the wrong uploaded package on the NuGet. There is no way to solve it now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.