Update push.yml

[cschuchardt88]

ONLY MERGE IF NEEDED FOR FIX #358 (comment)

[cschuchardt88]

Run dotnet nuget push ./out/*.nupkg --source https://www.myget.org/F/neo/api/v3/index.json --api-key ${MYGET_TOKEN}
Required argument missing for option: '--api-key'.

Specify --help for a list of available options and commands.
error: Missing value for option 'api-key'

[Jim8y]

Run dotnet nuget push ./out/*.nupkg --source https://www.myget.org/F/neo/api/v3/index.json --api-key ${MYGET_TOKEN}
Required argument missing for option: '--api-key'.

Specify --help for a list of available options and commands.
error: Missing value for option 'api-key'

Wait a minute, did you run it on your own repo? or you run it here? Its triggered on push, will only be run here if i merge it.

[cschuchardt88]

no i didnt https://github.com/neo-project/neo-express/actions/runs/6965238723

[cschuchardt88]

looks like it working now.

[Jim8y]

@cschuchardt88 https://github.com/neo-project/neo-express/actions/runs/6976519481

- name: Upload Build Log
  if: always()
  uses: actions/upload-artifact@v3
  with:
    name: buildlog
    path: ./msbuild.binlog

- name: Upload NeoExpress
  uses: actions/upload-artifact@v3
  with:
    name: packages
    path: ./out/*.nupkg

This creates a 90MB file to github storage on every run, can you figure out a way to avoid this? maybe no upload and download process but merge pack and publish jobs together? neo-project only has 500 MB storage, around 5 commits will consume all storage.

[cschuchardt88]

@Liaojinghui

i didnt see symbol get uploaded? Can you check?

myget says for symbols
https://docs.myget.org/docs/reference/symbols

If .nupkg and .snupkg packages are in the same folder, you only need to us push command for nupkg (we will detect the .snupkg and push it for you):

[Jim8y]

It is even enabled? i do not see its configed in neoxp

[Jim8y]

By the way,lets try to work on development branch, will need to update workflows to support development branch. In that branch i have more permission to work much more flexible.

[cschuchardt88]

@Liaojinghui its in Directory.Build.props

<SymbolPackageFormat>snupkg</SymbolPackageFormat>

[cschuchardt88]

@Liaojinghui now if we combine pack and publish, then it will publish on PRs too? is that ok?

[Jim8y]

No, cant way not run pack on pr?

[cschuchardt88]

Look at #371 i think its ok?

[Jim8y]

@Liaojinghui its in Directory.Build.props

<SymbolPackageFormat>snupkg</SymbolPackageFormat>

<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>