Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed/Changed Policy sync command #361

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Fixed/Changed Policy sync command #361

merged 4 commits into from
Nov 23, 2023

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Nov 18, 2023 •
edited
Loading

Change Log

  • Changed argument account to option. Can support default policy file now.
    • Default Filename: default-policy.json

Batch file

Change Log

  • Changed argument account to be an option. Example: policy sync -a genesis
  • Fixed policy sync not recognizing mainnet or testnet as an argument.

@cschuchardt88
Copy link
Member Author

@Liaojinghui any word on this?

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 22, 2023 •
edited
Loading

This needs #358 to be merged 1st for test to pass for neoxp

Edit:
Nevermind is its not needed.

@Jim8y Jim8y merged commit ed9254c into neo-project:master Nov 23, 2023
2 checks passed
@cschuchardt88 cschuchardt88 deleted the default-policy-resync branch November 23, 2023 00:36
@cschuchardt88 cschuchardt88 mentioned this pull request Dec 3, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jim8y Jim8y Jim8y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cschuchardt88 @Jim8y