Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default filenames and fixes #346

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Nov 16, 2023

Change Log

  • Updated batch command to use ResolveFileName for new default path
  • Fixed bug with ResolveFileName; not adding extension
  • Added default policy filename
  • Removed policy sync on create command
  • Fixed bug with sync not being used in batch files
  • Changed sync resolve path for default policy and to resolve to global directory
  • Added defaults for setup.batch on create command

Directory %userprofile%\.neo-express defaults
image

Example content

checkpoint create checkpoints/init-blockchain -f
policy sync mainnet-policy genesis
checkpoint create checkpoints/policy-sync-mainnet -f

Fixed bug with ResolveFileName; not adding extension
Removed policy sync on create command
Fixed bug with sync not being used in batch files
Changed sync resolve path for default policy
@cschuchardt88 cschuchardt88 marked this pull request as draft November 16, 2023 16:18
@cschuchardt88 cschuchardt88 changed the title Added defaults files and fixes Added default filenames and fixes Nov 16, 2023
@cschuchardt88
Copy link
Member Author

I have done basic testing... but maybe someone that uses neo-express can test it better. Im to new to using. I normally use neo-cli for testing

@cschuchardt88 cschuchardt88 marked this pull request as ready for review November 16, 2023 16:27
@Jim8y Jim8y merged commit 51e9833 into neo-project:master Nov 16, 2023
1 check passed
@cschuchardt88 cschuchardt88 deleted the default-files branch November 16, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants