Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use testnet/mainnet network configuration #335

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Use testnet/mainnet network configuration #335

merged 7 commits into from
Nov 15, 2023

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Nov 15, 2023 •
edited
Loading

Closes #332

Change Log

  • Added sync policy on create command

image

@cschuchardt88 cschuchardt88 mentioned this pull request Nov 15, 2023
Closed
lock9
lock9 requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@lock9 lock9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UT? 😅
Some inline comments could also help

@cschuchardt88 cschuchardt88 mentioned this pull request Nov 15, 2023
Closed
@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 15, 2023 •
edited
Loading

UT would be nice, But were to start... I test everything by debugging, Yes it isn't good enough. That's all we have atm. I'm waiting to see if Blockchain-toolkit-library gets added to this repo... so i can rebuild and get the UTs

@cschuchardt88 cschuchardt88 mentioned this pull request Nov 15, 2023
Open
@Jim8y Jim8y merged commit 21d382c into neo-project:master Nov 15, 2023
@cschuchardt88 cschuchardt88 deleted the issue-332 branch November 15, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lock9 lock9 lock9 requested changes

@Jim8y Jim8y Jim8y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use testnet/mainnet network configuration
3 participants
@cschuchardt88 @Jim8y @lock9