Blockchain Storage Path

[chenzhitong]

close #283

Can we store the blockchain file in the root directory of the program, like neo-cli, instead of store in AppData folder.

[chenzhitong]

@cschuchardt88 @lock9 @RichardBelsum @ixje

Can we store the blockchain file in the root directory of the program, like neo-cli, instead of store in AppData folder.

[cschuchardt88]

Ya i can't see why not. It's annoying to have to goto AppData folder.

Edit:
But you should be using checkpoints to rollback changes and such

[ixje]

That sounds good.

[chenzhitong]

Edit: But you should be using checkpoints to rollback changes and such

@cschuchardt88 I don't get it. What should I do?

[cschuchardt88]

But we should change the directory to base directory.

[ixje]

I'm also not following your checkpoint comments. Perhaps you can describe what we're supposed to see in that screenshot and why that is (or is not) a problem?

As for where to store the data; either in the same folder as the neo-express configuration file, or make it configurable through the neo-express configuration file. And to make it backwards compatible you can say the default is "in the same folder as the config file" if not specified/present in the file.

[Jim8y]

Merge?

[Ashuaidehao]

May need more test to check if the checkpoint command can run normally after this change.
For example, I can copy the "default.neo-express" file to any project folders, then run neoxp commands, it can find the same folder where the chaindata stored, I'm not sure if it still work in this PR.

[chenzhitong]

May need more test to check if the checkpoint command can run normally after this change. For example, I can copy the "default.neo-express" file to any project folders, then run neoxp commands, it can find the same folder where the chaindata stored, I'm not sure if it still work in this PR.

work

[cschuchardt88]

As for where to store the data; either in the same folder as the neo-express configuration file, or make it configurable through the neo-express configuration file. And to make it backwards compatible you can say the default is "in the same folder as the config file" if not specified/present in the file.

Can we do this? This is a big change. And there maybe apps that on that location.

[Ashuaidehao]

May need more test to check if the checkpoint command can run normally after this change. For example, I can copy the "default.neo-express" file to any project folders, then run neoxp commands, it can find the same folder where the chaindata stored, I'm not sure if it still work in this PR.

work

It also has an offline mode, just stop the running command window and run neoxp in another folders.

[Ashuaidehao]

And you should test more commands like neoxp show tx 0xXXX, neoxp contract deploy xx.nef and so on. This PR will not just change neoxp run command behavior.

[chenzhitong]

I know why it's stored in the AppData folder, because it was installed through the dotnet tool at that time, and now it can be run as a standalone application, so it doesn't need to be stored in the AppData folder anymore.

PS: dotnet tool install Neo.Express -g are installed in the following directories by default:

OS	Path
Linux/macOS	$HOME/.dotnet/tools
Windows	%USERPROFILE%\.dotnet\tools

[chenzhitong]

And you should test more commands like neoxp show tx 0xXXX, neoxp contract deploy xx.nef and so on. This PR will not just change neoxp run command behavior.

Test Passed

[cschuchardt88]

I'm also not following your checkpoint comments. Perhaps you can describe what we're supposed to see in that screenshot and why that is (or is not) a problem?

I was talking about this See Below

May need more test to check if the checkpoint command can run normally after this change.
For example, I can copy the "default.neo-express" file to any project folders, then run neoxp commands, it can find the same folder where the chaindata stored, I'm not sure if it still work in this PR.

@chenzhitong test the above.

Also you have the unit test project for this as well. You can create a project unit test for a contracts. Lets not forget about that. If you need help with a template for contract unit test for neo-express let me know.

[cschuchardt88]

You should change the path to match #324 Should be alot easier to understand for the user.

[Jim8y]

You should change the path to match #324 Should be alot easier to understand for the user.

@chenzhitong Any update?