Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NEP2/6 support #142

Merged
merged 13 commits into from
May 13, 2021
Merged

Add NEP2/6 support #142

merged 13 commits into from
May 13, 2021

Conversation

devhawk
Copy link
Contributor

@devhawk devhawk commented May 13, 2021

This PR adds support for standard string based addresses, NEP-2 encoded private keys and NEP-6 wallets.

Commands that require an address for non signing purposes (show balance, show balances, transfer receiver) now support standard Neo addresses in additon to neo express wallet names.

Commands that require an address for signing purposes (contract deploy, contract invoke, transfer sender) now can accept a NEP-2 encoded private key or the path to a NEP-6 wallet in addition to a neo-express wallet name. Since NEP-2 and NEP-6 are both password protected, those commands now support a -p/--password option so that the password can be provided on the command line. Note, -p/--password option is usable in both normal and batch mode.

For non-batch mode, if the user doesn't specify a neo-express wallet for a signing address, neo-express will prompt the user interactively for the password.

fix #103

@devhawk devhawk requested review from djnicholson, JohndeVadoss, longfeiWan9 and a team May 13, 2021 19:46
@devhawk devhawk merged commit c716578 into master May 13, 2021
@devhawk devhawk deleted the devhawk/issue103 branch May 13, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NEP-6
2 participants