Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Enrich Handlers and the option to filters and create activity with each invocation context. #62

Conversation

npandrei
Copy link

Added Enrich Handlers similar to AspNetCoreTraceInstrumentationOptions and the option to filter and create activity with each invocation context.

…s and the option to filter and create activity with each invocation context
@npandrei
Copy link
Author

Still need to do some testing, but before spending too much time, I want to double check if you agree with this approach. The library works well, so hats down for the work done so far, but I've felt the need of :

  • some extensions points where I can alter the current activity based on the invocation/result
  • the ability to filter out some activities/spans, as with Blazor Server hosting approach, it is a bit noisy to see "ComponentRendered" messages
  • with Blazor Server, all the spans seem to be descendants of HubConnectionContext.OriginalActivity, which on long lived sessions makes debugging very difficult

@npandrei npandrei changed the title Added Enrich Handlers and the option to filters and create activity with each invocation context. Jan 13, 2025
@nenoNaninu
Copy link
Owner

Thank you for the PR.

  • some extensions points where I can alter the current activity based on the invocation/result
  • the ability to filter out some activities/spans, as with Blazor Server hosting approach, it is a bit noisy to see "ComponentRendered" messages
  • with Blazor Server, all the spans seem to be descendants of HubConnectionContext.OriginalActivity, which on long lived sessions makes debugging very difficult

These demands make sense, so I will support them. However, I am not satisfied with the changes made to this PR in several respects, so I am closing it.

@nenoNaninu nenoNaninu closed this Jan 16, 2025
@npandrei
Copy link
Author

Sure, this was something quickly put together just to POC that it is doable before reaching out. Do you have availability to make these changes in the near future? And, if so, could you tag me when you merge the changes so I can get the latest version? Thanks !

This was referenced Jan 25, 2025
@nenoNaninu
Copy link
Owner

nenoNaninu commented Jan 27, 2025

@npandrei

  • the ability to filter out some activities/spans, as with Blazor Server hosting approach, it is a bit noisy to see "ComponentRendered" messages
  • with Blazor Server, all the spans seem to be descendants of HubConnectionContext.OriginalActivity, which on long lived sessions makes debugging very difficult

These two points were supported from v1.6.0. Try it!

@npandrei
Copy link
Author

npandrei commented Feb 4, 2025

@nenoNaninu will give it a try, thanks ! might be some time until I can do it though, had to switch my focus to something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants