Merge pull request #78 from nenoNaninu/f/refactor_use_trace_context2

refactor
nenoNaninu · Jan 27, 2025 · 9f86402 · 9f86402
2 parents 5fc8da3 + e1753d3
commit 9f86402
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/AspNetCore.SignalR.OpenTelemetry/HubInstrumentationFilter.cs b/src/AspNetCore.SignalR.OpenTelemetry/HubInstrumentationFilter.cs
@@ -131,7 +131,9 @@ public async Task OnDisconnectedAsync(
     {
         var previousActivity = Activity.Current;
 
-        if (previousActivity is not null && !_options.UseParentTraceContext)
+        var shouldClearParentTraceContext = previousActivity is not null && !_options.UseParentTraceContext;
+
+        if (shouldClearParentTraceContext)
         {
             Activity.Current = null;
         }
@@ -173,8 +175,9 @@ public async Task OnDisconnectedAsync(
         }
         finally
         {
-            if (previousActivity is not null && !_options.UseParentTraceContext)
+            if (shouldClearParentTraceContext)
             {
+                // restore previous activity
                 Activity.Current = previousActivity;
             }
         }