@orta => Replaced NATiledImageView with ARTiledImageView #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| @interface NADotAnnotation : NAAnnotation | ||
|
|
||
| // Dot radius. |
There was a problem hiding this comment.
Looks like they all need this, after accepting this PR I'll do a documentation run, http://cocoadocs.org/docsets/NAMapKit/3.0/Classes/NAMapView.html
|
also travis doesn't seem to be running on this PR, is this a bug? |
|
looking at CI, not sure what's up |
|
@orta CI still runs XCode 5.0.2 and those screenshots aren't the same. There's travis-ci/travis-ci#2051 to update that and there's facebookarchive/ios-snapshot-test-case#19 that seems to address this as well. I think this is safe to merge, locally all these tests pass for me, we'll fix them before the next release one way or another, of course. |
|
Sure. |
orta
added a commit
that referenced
this pull request
Mar 17, 2014
@orta => Replaced NATiledImageView with ARTiledImageView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ARTiledImageView pod, as well as a number of misc fixes and improvements.