Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #134: use an UncontrolledPopover to fix popovers for Safari #144

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

gj262
Copy link
Collaborator

@gj262 gj262 commented Mar 23, 2020

Description

Help information would not display for Safari users.

Related issues

Fixes #134

Impacted Areas in the application

Help Popovers.

Testing

  • Tested with Chrome & Safari on MacOS
  • Changed the help popover unit test to use clicks

Deploy Notes

None

@vercel
Copy link

vercel bot commented Mar 23, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/covid19-scenarios/covid19-scenarios/q3uyse4kj
✅ Preview: https://covid19-scenarios-git-fork-gj262-fixsafaripopoverii.covid19-scenarios.now.sh

@gj262
Copy link
Collaborator Author

gj262 commented Mar 23, 2020

HI @ivan-aksamentov. This one looks like it works. I think I had some errant code in the previous PR but just could not see it. Sorry about that. So your travis change may be unnecessary.

@ivan-aksamentov ivan-aksamentov merged commit 6ddaba7 into neherlab:master Mar 23, 2020
@ivan-aksamentov
Copy link
Member

@gj262 It's okay, I wanted to bust this cache from the beginning :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Safari help text does not appear on clicking the help buttons
2 participants