-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #134: use an UncontrolledPopover to fix popovers for Safari #141
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/covid19-scenarios/covid19-scenarios/671td2q3p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix the tests also:
https://travis-ci.org/github/neherlab/covid19_scenarios/builds/665694547#L393-L1022
(except for type errors, ignore the them for now)
This is a bizarre CI failure given that the |
Indeed, local tests pass. Do you see anything immediately wrong with the travis setup: |
@gj262 I disabled and cleared the cache. Could you please rebase on master to see if it helps? |
hmmm, I seem to have made a git mess :( And it is still not working for the same error. I'm gonna try a new branch and then give up for the night :) |
Description
Help information would not display for Safari users.
Related issues
Fixes #134
Impacted Areas in the application
Help Popovers.
Testing
Deploy Notes
None