Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #134: use an UncontrolledPopover to fix popovers for Safari #141

Closed
wants to merge 7 commits into from

Conversation

gj262
Copy link
Collaborator

@gj262 gj262 commented Mar 23, 2020

Description

Help information would not display for Safari users.

Related issues

Fixes #134

Impacted Areas in the application

Help Popovers.

Testing

  • Tested with Chrome & Safari on MacOS
  • Changed the help popover unit test to use clicks

Deploy Notes

None

@vercel
Copy link

vercel bot commented Mar 23, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/covid19-scenarios/covid19-scenarios/671td2q3p
✅ Preview: https://covid19-scenarios-git-fork-gj262-fixsafaripopover.covid19-scenarios.now.sh

Copy link
Member

@ivan-aksamentov ivan-aksamentov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the tests also:
https://travis-ci.org/github/neherlab/covid19_scenarios/builds/665694547#L393-L1022
(except for type errors, ignore the them for now)

@gj262
Copy link
Collaborator Author

gj262 commented Mar 23, 2020

This is a bizarre CI failure given that the popoverOpen variable is gone now...

@ivan-aksamentov
Copy link
Member

Indeed, local tests pass.

Do you see anything immediately wrong with the travis setup:
https://github.com/neherlab/covid19_scenarios/blob/master/.travis.yml
?

@ivan-aksamentov
Copy link
Member

@gj262 I disabled and cleared the cache. Could you please rebase on master to see if it helps?

@gj262
Copy link
Collaborator Author

gj262 commented Mar 23, 2020

hmmm, I seem to have made a git mess :( And it is still not working for the same error. I'm gonna try a new branch and then give up for the night :)

@gj262 gj262 closed this Mar 23, 2020
@gj262 gj262 deleted the fixSafariPopover branch March 23, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Safari help text does not appear on clicking the help buttons
2 participants