fix: add support for caretHidden prop in TextInput #2542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3327e16:
|
Closed
6 tasks
s77rt
reviewed
Jun 22, 2023
| @@ -402,6 +403,7 @@ const TextInput: React.AbstractComponent< | |||
| { '--placeholderTextColor': placeholderTextColor }, | |||
| styles.textinput$raw, | |||
| styles.placeholder, | |||
| caretHidden && styles.caretHidden, | |||
There was a problem hiding this comment.
Shouldn't this style be the last not to be overwritten by props.style?
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds support for
caretHiddenprop in TextInput component.Adding
caretHiddenprop should ideally hide the text insertion caret on browsers. This is not working right now. This PR intends to fix the issue by settingcaretColorastransparentwhile this prop is used.fixes #2541