(fix) Make children interactive when parent pressable is disabled #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e4177c8:
|
jennifer-dickinson
changed the title
|
Thanks for looking into this and putting up a PR |
|
This fix is included in 0.19.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue: #2391.
It fixes the inconsistency between native builds and react-native-web, where when disabling Pressables and other tappable elements, the children on native builds are still interactable (swiping, tapping, etc) but un-interactable in react-native-web. On react-native-web, the pointerEvents were set to 'none' to address 094bd0e, which causes this inconsistency.
The solution was to change from 'none' to 'box-none', which maintains the desired behavior of the original issue and addresses the current.