Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nav trigger interaction #31

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

calebjacob
Copy link
Collaborator

Closes: #28

While making these changes, I also found a couple other small issues that I fixed:

  • Cookie prompt z index wasn't set, so certain elements were overlapping it.
  • Our pre-commit command wasn't properly exiting when an ES Lint warning existed
  • React was complaining about non-unique key values for the news section since two posts had duplicate titles.

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nearorg-container ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 4:39pm

…ite" - we want the pre-commit command to throw an error if any formatting is incorrect
@calebjacob calebjacob merged commit 5abf63a into develop May 23, 2024
1 of 2 checks passed
@calebjacob calebjacob deleted the fix/nav-trigger-interaction branch May 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the navbar elements closes the dropdown
2 participants