Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evm): EVM standard borsh args + refactoring #3581

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

evgenykuzyakov
Copy link
Collaborator

  • BREAKING: Added FunctionCallArgs structure and changed function call args to require this input. It adds 4 bytes for the size of RLP encoded input before the input. Makes function_call args a standard borsh structure
  • BREAKING: Updated ViewCallArgs to be standard borsh structure. Same 4 bytes in front of the input
  • Fix: Updated gas accounting for view calls, meta calls, and fixed alias function call when counting gas.
  • Added a bunch of TODO.
  • Refactor: Created enum for Method to be explicit about method_name and parse it only once.
  • Refactor: Updated storage to avoid some key copies
  • Refactored some duplicated code for converting interpreter call result
  • Refactor: Removed some cloning from input

Test plan:

  • standard unit test is still failing, probably because of the invalid solidity binary.

@evgenykuzyakov evgenykuzyakov changed the title feat(evm): Evm upgradeable args feat(evm): EVM standard borsh args + refactoring Nov 9, 2020
Copy link
Contributor

@artob artob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@artob artob added A-EVM Area: Native EVM implementation and support C-housekeeping Category: Refactoring, cleanups, code quality labels Nov 10, 2020
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@evgenykuzyakov evgenykuzyakov merged commit a7dcfd5 into evm-precompile Nov 10, 2020
@evgenykuzyakov evgenykuzyakov deleted the evm-upgradeable-args branch November 10, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-EVM Area: Native EVM implementation and support C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants