-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move fns as default implementation in EpochManagerAdapter trait #12853
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12853 +/- ##
==========================================
+ Coverage 70.39% 70.40% +0.01%
==========================================
Files 851 851
Lines 174188 174105 -83
Branches 174188 174105 -83
==========================================
- Hits 122614 122579 -35
+ Misses 46327 46282 -45
+ Partials 5247 5244 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
let epoch_manager = self.read(); | ||
epoch_manager.get_all_block_approvers_ordered(parent_hash) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do want to inline it as part of EpochManagerHandle
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no good reason. reverted with a minor modification
The PR makes some functions as default implementation in the
EpochManagerAdapter
trait and deletes unused functions likecopy_epoch_info_as_of_block
andget_all_block_approvers_ordered