Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] refactor: default function implementations in EpochManagerAdapter trait #12850

Closed
wants to merge 3 commits into from

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Jan 31, 2025

No description provided.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 70.86614% with 37 lines in your changes missing coverage. Please review.

Project coverage is 70.39%. Comparing base (8b861f8) to head (e12f05b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
chain/epoch-manager/src/adapter.rs 70.86% 5 Missing and 32 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12850      +/-   ##
==========================================
- Coverage   70.40%   70.39%   -0.02%     
==========================================
  Files         851      851              
  Lines      174188   174194       +6     
  Branches   174188   174194       +6     
==========================================
- Hits       122634   122619      -15     
- Misses      46311    46327      +16     
- Partials     5243     5248       +5     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (-0.01%) ⬇️
db-migration 0.16% <0.00%> (-0.01%) ⬇️
genesis-check 1.41% <0.00%> (-0.01%) ⬇️
linux 70.07% <70.86%> (+0.01%) ⬆️
linux-nightly 70.01% <70.86%> (-0.03%) ⬇️
pytests 1.71% <0.00%> (-0.01%) ⬇️
sanity-checks 1.52% <0.00%> (-0.01%) ⬇️
unittests 70.22% <70.86%> (-0.02%) ⬇️
upgradability 0.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stedfn stedfn closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant