Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify MakeSnapshotCallback #12849

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

Trisfald
Copy link
Contributor

Remove one unnecessary parameter from the function type MakeSnapshotCallback.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.40%. Comparing base (94abfca) to head (b56ed89).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
chain/chain/src/chain.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12849      +/-   ##
==========================================
+ Coverage   70.37%   70.40%   +0.03%     
==========================================
  Files         848      851       +3     
  Lines      174870   174188     -682     
  Branches   174870   174188     -682     
==========================================
- Hits       123064   122641     -423     
+ Misses      46547    46306     -241     
+ Partials     5259     5241      -18     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.41% <0.00%> (-0.01%) ⬇️
linux 70.06% <94.44%> (+0.07%) ⬆️
linux-nightly 70.05% <94.44%> (+0.03%) ⬆️
pytests 1.71% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.52% <0.00%> (-0.01%) ⬇️
unittests 70.23% <94.44%> (+0.02%) ⬆️
upgradability 0.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Trisfald Trisfald marked this pull request as ready for review January 31, 2025 09:52
@Trisfald Trisfald requested a review from a team as a code owner January 31, 2025 09:52
@Trisfald Trisfald added this pull request to the merge queue Jan 31, 2025
Merged via the queue into near:master with commit 8b861f8 Jan 31, 2025
28 of 29 checks passed
@Trisfald Trisfald deleted the refactor-callback branch January 31, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants