Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVM] Add tests for all EVM precompiles #3628

Closed
artob opened this issue Nov 18, 2020 · 1 comment
Closed

[EVM] Add tests for all EVM precompiles #3628

artob opened this issue Nov 18, 2020 · 1 comment
Assignees
@artob
Labels
A-EVM Area: Native EVM implementation and support A-testing Area: Unit testing / integration testing C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@artob
Copy link
Contributor

artob commented Nov 18, 2020

As discussed on recent EVM team sync calls, we need tests to validate the standard EVM precompiles, as well as going forward our custom EVM precompiles (for example, #3449).

References:
@artob artob added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-testing Area: Unit testing / integration testing A-EVM Area: Native EVM implementation and support labels Nov 18, 2020
@artob artob self-assigned this Nov 18, 2020
artob added a commit that referenced this issue Nov 18, 2020
@artob
Added test cases for standard EVM precompiles. (#3628) WIP
6191c78
artob added a commit that referenced this issue Nov 19, 2020
@artob
Added test cases for standard EVM precompiles. (#3628) WIP
765fb39
artob added a commit that referenced this issue Nov 19, 2020
@artob
Added test cases for standard EVM precompiles. (#3628) WIP
8d82c93
artob added a commit that referenced this issue Nov 20, 2020
@artob
Added test cases for standard EVM precompiles. (#3628)
e06038e
artob added a commit that referenced this issue Nov 20, 2020
@artob
Added test cases for standard EVM precompiles. (#3628)
6a6df0d
@artob
Copy link
Contributor Author

artob commented Nov 20, 2020

Implemented in #3633.

@artob artob closed this as completed Nov 20, 2020
artob added a commit that referenced this issue Nov 20, 2020
@artob
Added test cases for standard EVM precompiles. (#3628)
03e53d0
artob added a commit that referenced this issue Nov 20, 2020
@artob
Added test cases for standard EVM precompiles. (#3628)
525f57d
evgenykuzyakov pushed a commit that referenced this issue Nov 25, 2020
@artob
Added test cases for standard EVM precompiles. (#3628) (#3633)
14fccf1 
The tests can be run with:

```bash
cargo test --package nearcore --test test_cases_runtime test::test_evm_call_standard_precompiles_runtime --features protocol_feature_evm,nightly_protocol_features -- --exact
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artob artob

Labels
A-EVM Area: Native EVM implementation and support A-testing Area: Unit testing / integration testing C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artob