Feat/payout #778
Feat/payout #778
Conversation
| @@ -2,7 +2,7 @@ | |||
| members = [ | |||
| "near-sdk", | |||
| "near-sdk-macros", | |||
| "near-sdk-sim", | |||
| "near-sdk-sim", | |||
There was a problem hiding this comment.
can you revert this spacing?
| @@ -426,7 +431,10 @@ impl NonFungibleTokenCore for NonFungibleToken { | |||
| msg: String, | |||
| ) -> PromiseOrValue<bool> { | |||
| assert_one_yocto(); | |||
| require!(env::prepaid_gas() > GAS_FOR_NFT_TRANSFER_CALL, "More gas is required"); | |||
| require!( | |||
| env::prepaid_gas() > GAS_FOR_NFT_TRANSFER_CALL + GAS_FOR_RESOLVE_TRANSFER, | |||
There was a problem hiding this comment.
revert this change please
| @@ -12,6 +12,9 @@ mod macros; | |||
| /// Metadata traits and implementation according to the [NFT enumeration standard](https://nomicon.io/Standards/NonFungibleToken/Metadata.html). | |||
| /// This covers both the contract metadata and the individual token metadata. | |||
| pub mod metadata; | |||
|
|
|||
| pub mod payout; | |||
There was a problem hiding this comment.
Module isn't documented here or in .../payout/mod.rs,
can you describe this and link to the spec there using //! rustdoc comments at the top of the file, please?
| /* pub fn new(accounts: HashMap<AccountId, u8>, percent: u8) -> Self { | ||
| let this = Self { accounts, percent }; | ||
| this.validate(); | ||
| this | ||
| } */ |
There was a problem hiding this comment.
| /* pub fn new(accounts: HashMap<AccountId, u8>, percent: u8) -> Self { | |
| let this = Self { accounts, percent }; | |
| this.validate(); | |
| this | |
| } */ |
| use std::collections::HashMap; | ||
| impl Royalties { |
There was a problem hiding this comment.
| use std::collections::HashMap; | |
| impl Royalties { | |
| use std::collections::HashMap; | |
| impl Royalties { |
| } | ||
|
|
||
| fn apply_percent(percent: u8, int: u128) -> u128 { | ||
| int * percent as u128 / 100u128 |
There was a problem hiding this comment.
Seems like this can overflow, are there any guarantees around this? Probably want to do a checked multiplication with an expect to make sure someone doesn't need overflow-checks enabled to catch this
| pub struct Royalties { | ||
| key_prefix: Vec<u8>, | ||
| pub accounts: HashMap<AccountId, u8>, | ||
| pub percent: u8, |
There was a problem hiding this comment.
Should use basis points: see https://github.com/TENK-DAO/tenk/blob/main/contracts/tenk/src/payout.rs
| #[serde(crate = "near_sdk::serde")] | ||
| pub struct Royalties { | ||
| key_prefix: Vec<u8>, | ||
| pub accounts: HashMap<AccountId, u8>, |
There was a problem hiding this comment.
Also should be basis points.
|
How long this feature should be merged into? |
|
@thaibao-incognito, there is no timeline. If you want to use this today, here is a complete example: https://github.com/TENK-DAO/tenk/blob/main/contracts/tenk/src/payout.rs |
|
FYI, Payout NFT standard was aligned with the implementation: near/NEPs#276 This PR is almost there, and it seems only the last mile is left, so I hope NEAR community can make this final push here |
Takes #673 closer to the final stage