Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check in ci that yarn build generated files are included/updated #219

Merged
merged 8 commits into from
Sep 15, 2022
Merged

check in ci that yarn build generated files are included/updated #219

merged 8 commits into from
Sep 15, 2022

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Sep 14, 2022

We didn't have a check to ensure changes on ts files are built and committed. So I add this check

@ailisp ailisp requested a review from volovyks as a code owner September 14, 2022 02:50
volovyks
volovyks approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! So, it will fail if after yarn build we will have something in git diff right?

@ailisp
Copy link
Member Author

ailisp commented Sep 15, 2022

@volovyks Yes. git status must be clean

@volovyks volovyks merged commit c77f842 into develop Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ailisp @volovyks