Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename plain object -> class instance operation to "reconstruct" #218

Merged
merged 3 commits into from
Sep 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/collections/lookup-map.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/collections/lookup-map.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/collections/lookup-set.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/collections/lookup-set.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/collections/unordered-map.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/collections/unordered-map.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/collections/unordered-set.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/collections/unordered-set.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/collections/vector.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/collections/vector.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions lib/near-bindgen.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/collections/lookup-map.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class LookupMap {
}

// converting plain object to class object
static deserialize(data: LookupMap): LookupMap {
static reconstruct(data: LookupMap): LookupMap {
return new LookupMap(data.keyPrefix)
}
}
2 changes: 1 addition & 1 deletion src/collections/lookup-set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class LookupSet {
}

// converting plain object to class object
static deserialize(data: LookupSet): LookupSet {
static reconstruct(data: LookupSet): LookupSet {
return new LookupSet(data.keyPrefix)
}
}
2 changes: 1 addition & 1 deletion src/collections/unordered-map.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class UnorderedMap {
}

// converting plain object to class object
static deserialize(data: UnorderedMap): UnorderedMap {
static reconstruct(data: UnorderedMap): UnorderedMap {
// removing readonly modifier
type MutableUnorderedMap = Mutable<UnorderedMap>;
let map = new UnorderedMap(data.prefix) as MutableUnorderedMap;
Expand Down
2 changes: 1 addition & 1 deletion src/collections/unordered-set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export class UnorderedSet {
}

// converting plain object to class object
static deserialize(data: UnorderedSet): UnorderedSet {
static reconstruct(data: UnorderedSet): UnorderedSet {
// removing readonly modifier
type MutableUnorderedSet = Mutable<UnorderedSet>;
let set = new UnorderedSet(data.prefix) as MutableUnorderedSet;
Expand Down
2 changes: 1 addition & 1 deletion src/collections/vector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export class Vector {
}

// converting plain object to class object
static deserialize(data: Vector): Vector {
static reconstruct(data: Vector): Vector {
let vector = new Vector(data.prefix);
vector.length = data.length;
return vector;
Expand Down
4 changes: 2 additions & 2 deletions src/near-bindgen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ export function NearBindgen({ requireInit = false }: { requireInit?: boolean })

static _reconstruct(classObject: any, plainObject: JSON) {
for (const item in classObject) {
if (classObject[item].constructor?.deserialize !== undefined) {
classObject[item] = classObject[item].constructor.deserialize(plainObject[item])
if (classObject[item].constructor?.reconstruct !== undefined) {
classObject[item] = classObject[item].constructor.reconstruct(plainObject[item])
} else {
classObject[item] = plainObject[item]
}
Expand Down