Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add includeBytes "macro" that helps factory contract #206

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Sep 7, 2022

Address #189

diff was too big to show in github.

before:
image

after:
image

@ailisp ailisp marked this pull request as ready for review September 7, 2022 12:07
@ailisp ailisp requested a review from volovyks as a code owner September 7, 2022 12:07
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Should we include this updated babel.config in all the projects? Ot it is expected to be used rearly?

@volovyks volovyks merged commit 6ec568c into develop Sep 7, 2022
@ailisp
Copy link
Member Author

ailisp commented Sep 8, 2022

Cool! Should we include this updated babel.config in all the projects?

Yes it should in for all projects, is there a way to do it in near-sdk-js side?

@volovyks
Copy link
Collaborator

volovyks commented Sep 8, 2022

Now we need to include it manually. But it's added automatically if the project is created with create-near-app.
@gagdiez let's not forget to add it.

@ailisp ailisp deleted the include-bytes branch September 8, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants