-
Notifications
You must be signed in to change notification settings - Fork 56
feat(frontend): Display receipts on Block Details page #643
Conversation
Your Render PR Server URL is https://near-explorer-frontend-with-indexer-pr-qnuq.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-c2mm9o0irho0o0tj3680. |
There are list of receipts on blocks page. Also added a link to receipt on transaction (if such transaction is created). There is some things to do with Action* components so I'll carefully align it and cleaned up. |
@frol , does we need to show timestamp of receipt as it shown on TransactionActions? |
Your Render PR Server URL is . Follow its progress at https://dashboard.render.com/worker/srv-c2of7b0irho5ka7j25v0. |
9c7204b
to
cd7ed7d
Compare
cd7ed7d
to
5458efd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not reviewed explorer-wamp/receipts.ts
yet.
if (!children && !text) { | ||
throw new Error("Placeholder's text should not be empty"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just choose one, either children
or text
(I would go with children
) and set it required on TypeScript Props interface, so we don't need these runtime checks
89aa286
to
ef77c62
Compare
ef77c62
to
f4c9f91
Compare
35226b9
to
2b8f43a
Compare
Bugs:
|
Bugs:
|
…t-actions groupping
…imply as 'Succeeded' to the end-user (we only care about the details when display the whole transaction execution plan)
…ceeded' status for the Receipt SucceessReceiptId variant
…nd ReceiptsInBlock component
Resolves:
Test Plan: