Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

feat(frontend): Display receipts on Block Details page #643

Merged
merged 14 commits into from
Jun 8, 2021

Conversation

shelegdmitriy
Copy link
Contributor

@shelegdmitriy shelegdmitriy commented May 25, 2021

@shelegdmitriy shelegdmitriy requested a review from frol May 25, 2021 20:58
@shelegdmitriy shelegdmitriy self-assigned this May 25, 2021
@render
Copy link

render bot commented May 25, 2021

@shelegdmitriy
Copy link
Contributor Author

There are list of receipts on blocks page. Also added a link to receipt on transaction (if such transaction is created). There is some things to do with Action* components so I'll carefully align it and cleaned up.

@shelegdmitriy
Copy link
Contributor Author

@frol , does we need to show timestamp of receipt as it shown on TransactionActions?

@shelegdmitriy shelegdmitriy changed the title Feat/receipts on block details page Display receipts on Block Details page May 26, 2021
@frol frol changed the title Display receipts on Block Details page feat(frontend): Display receipts on Block Details page May 26, 2021
@render
Copy link

render bot commented May 28, 2021

Your Render PR Server URL is .

Follow its progress at https://dashboard.render.com/worker/srv-c2of7b0irho5ka7j25v0.

@shelegdmitriy shelegdmitriy force-pushed the feat/receipts_on_block_details_page branch from 9c7204b to cd7ed7d Compare May 28, 2021 13:44
@shelegdmitriy shelegdmitriy marked this pull request as ready for review May 28, 2021 13:59
@shelegdmitriy shelegdmitriy force-pushed the feat/receipts_on_block_details_page branch from cd7ed7d to 5458efd Compare May 28, 2021 14:00
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed explorer-wamp/receipts.ts yet.

frontend/src/components/blocks/BlockDetails.tsx Outdated Show resolved Hide resolved
frontend/src/components/blocks/BlockDetails.tsx Outdated Show resolved Hide resolved
frontend/src/components/transactions/ActionMessage.tsx Outdated Show resolved Hide resolved
frontend/src/components/transactions/ActionRow.tsx Outdated Show resolved Hide resolved
frontend/src/components/transactions/ActionRowBlock.tsx Outdated Show resolved Hide resolved
frontend/src/components/blocks/BlockDetails.tsx Outdated Show resolved Hide resolved
Comment on lines 8 to 10
if (!children && !text) {
throw new Error("Placeholder's text should not be empty");
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just choose one, either children or text (I would go with children) and set it required on TypeScript Props interface, so we don't need these runtime checks

frontend/src/components/utils/ExecutionReceiptStatus.tsx Outdated Show resolved Hide resolved
frontend/src/components/utils/ExecutionReceiptStatus.tsx Outdated Show resolved Hide resolved
frontend/src/components/utils/ReceiptHashLink.tsx Outdated Show resolved Hide resolved
@shelegdmitriy shelegdmitriy force-pushed the feat/receipts_on_block_details_page branch from 89aa286 to ef77c62 Compare June 2, 2021 10:51
@shelegdmitriy shelegdmitriy force-pushed the feat/receipts_on_block_details_page branch from ef77c62 to f4c9f91 Compare June 2, 2021 10:52
@shelegdmitriy shelegdmitriy force-pushed the feat/receipts_on_block_details_page branch from 35226b9 to 2b8f43a Compare June 2, 2021 12:54
@frol
Copy link
Collaborator

frol commented Jun 3, 2021

@frol
Copy link
Collaborator

frol commented Jun 3, 2021

Bugs:

frontend/src/libraries/explorer-wamp/receipts.ts Outdated Show resolved Hide resolved
@frol frol merged commit b471409 into master Jun 8, 2021
@frol frol deleted the feat/receipts_on_block_details_page branch June 8, 2021 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants