Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lockup [3.0.0]: Update lockup release duration #136

Merged
merged 1 commit into from
Apr 8, 2021
Merged

lockup [3.0.0]: Update lockup release duration #136

merged 1 commit into from
Apr 8, 2021

Conversation

evgenykuzyakov
Copy link
Collaborator

3.0.0

  • Release duration now starts from the moment the tokens are unlocked.
    The tokens are unlocked at the following timestamp max(transfers_enabled_timestamp + lockup_duration, lockup_timestamp).
    NOTE: If the lockup_timestamp is not specified, the tokens are unlocked at transfers_enabled_timestamp + lockup_duration.

The contracts were rebuilt using contract builder from near-sdk-rs

Test plan

  • Updated unittests and sim tests to match the new behavior

@ilblackdragon
Copy link
Member

Merge?

frol
frol approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped into the same issue, and confirm the fix is correct

@frol
Copy link
Contributor

frol commented Apr 7, 2021

FYI, contract-lookup has been also updated: near/account-lookup#4

@bowenwang1996 bowenwang1996 merged commit 39e0296 into master Apr 8, 2021
@bowenwang1996 bowenwang1996 deleted the fix-lockup-release branch April 8, 2021 01:35
@vgrichina vgrichina mentioned this pull request Apr 17, 2021
Merged
@frol frol mentioned this pull request Apr 19, 2021
Merged
@marcinbodnar marcinbodnar mentioned this pull request Apr 21, 2021
Closed
@maxzaver maxzaver mentioned this pull request Oct 21, 2021
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@willemneal willemneal willemneal approved these changes

@bowenwang1996 bowenwang1996 bowenwang1996 approved these changes

@ilblackdragon ilblackdragon Awaiting requested review from ilblackdragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evgenykuzyakov @ilblackdragon @frol @willemneal @bowenwang1996