Skip test determined to be related to dependency w/ JS issue #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agreed. For now, let's keep this open here. As long as we have a fixed branch (such as hotfix/skip-flawed-test) to clone to enable the use of Balancer tests in our CI, all is good. I still have opening an upstream issue on my to-do list, will get to it next week. (It will need a lot of elaboration.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how we want to approach this in terms of merging to
masteras I know we discussed keeping this change only on our own side. Either way, wanted to capture this. Perhaps when we're ready to make that pull request against the canonical balancer-core repo we can open it with branch off our master.This is also not urgent to merge, just helpful to tracking purposes and testing sanity.