add CARGO_HOME and simplify Gitpod Dockerfile #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f8ffeeb.
.gitpod.Dockerfile
Outdated
| RUN bash -cl "rustup toolchain install stable && rustup target add wasm32-unknown-unknown" | ||
| ENV CARGO_HOME=/home/gitpod/.cargo | ||
|
|
||
| RUN bash -cl "rustup default stable-2020-10-08-x86_64-unknown-linux-gnu && rustup target add wasm32-unknown-unknown" |
There was a problem hiding this comment.
it looks like we default to stable-2020-10-08 since we specify it in the rust-toolchain file. Should we upgrade it to latest stable? But otherwise everything else looks fine
There was a problem hiding this comment.
Great comments, thanks! Pushed up some changes
ChaoticTempest
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phuong discovered an env var that seems like it needs to be set for Gitpod now