Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MISRA C++ 2023 rule 13.3.3 "The parameters in all declarations or overrides of a function shall either be unnamed or have identical names" #632

Closed
mohammedRafeeque opened this issue Jun 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working c++ C++ language generator
Milestone

Comments

@mohammedRafeeque
Copy link

Zserio version and language
Zserio: latest from master
Commit date: 6 days ago (6/4/2024 7:12:28 PM)
Commit hash: b8cc6c0

Describe the bug
1 Misra warning getting reported

  1. void doDeallocate(void* resource, size_t, size_t) override
<style> </style>
SNo Rule Severity Message Filename Linenumber
1473 MISRACPP2023-13_3_3-b 2 The name of the parameter 'resource' is different from the name of the corresponding parameter 'storage' in the 'doDeallocate' virtual function in the 'MemoryResource' base class zserio_runtime/zserio/pmr/NewDeleteResource.h 26

Please check possibility of fixing the same.

Steps to reproduce the behavior:
SCA run using MISRA 2023 configuration.

Expected behavior
No SCA warnings for MISRA 2023 ruleset

Additional context
N.A

@Roland-Homeier @mikir FYI.

@mohammedRafeeque mohammedRafeeque added the bug Something isn't working label Jun 14, 2024
@mikir mikir changed the title Fix MISRA C++ 2023 rule MISRACPP2023-13_3_3-b The name of the parameter 'resource' is different from the name of the corresponding parameter 'storage' in the 'doDeallocate' virtual function in the 'MemoryResource' base class Fix MISRA C++ 2023 rule 13.3.3 "The parameters in all declarations or overrides of a function shall either be unnamed or have identical names" Jun 18, 2024
@mikir mikir added the c++ C++ language generator label Jun 18, 2024
@mikir mikir added this to the 2.15 milestone Jun 18, 2024
@mohammedRafeeque
Copy link
Author

By renaming the variable name from resource to storage we can resolve this warning.
From void doDeallocate(void* resource, size_t, size_t) override { ::operator delete(resource); }
to
void doDeallocate(void* storage, size_t, size_t) override { ::operator delete(storage); }

@Mi-La Mi-La self-assigned this Aug 8, 2024
@Mi-La
Copy link
Contributor

Mi-La commented Aug 8, 2024

Enabled Sonar Rule cpp:S5319 and fixed.

@Mi-La Mi-La closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c++ C++ language generator
Projects
None yet
Development

No branches or pull requests

3 participants