Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC produces some warnings in CI builds #587

Closed
Mi-La opened this issue Apr 9, 2024 · 0 comments
Closed

MSVC produces some warnings in CI builds #587

Mi-La opened this issue Apr 9, 2024 · 0 comments
Assignees
@mikir
Labels
bug Something isn't working c++ C++ language generator
Milestone
2.14.1

Comments

@Mi-La
Copy link
Contributor

Mi-La commented Apr 9, 2024 •
edited
Loading

CI builds with MSVC v141 and v142 toolsets produce some warning in our language tests and thus we cannot use ZSERIO_ENABLE_WERROR=1 for MSVC builds.

others\gif\gen\gif\gif_data\ImageDescriptor.cpp(655,12): error C2220: the following warning is treated as an error
others\gif\gen\gif\gif_data\ImageDescriptor.cpp(655,12): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
...
@Mi-La Mi-La added the bug Something isn't working label Apr 9, 2024
@Mi-La Mi-La added this to the Priority Backlog milestone Apr 9, 2024
@Mi-La Mi-La added the c++ C++ language generator label Apr 9, 2024
@mikir mikir modified the milestones: Priority Backlog, 2.15 Apr 18, 2024
mikir added a commit that referenced this issue May 6, 2024
@mikir
[#587] disable msvc warning 4334
ed3d470
mikir added a commit that referenced this issue May 7, 2024
@mikir
[#587] fix warning 4267
0c5d160
mikir added a commit that referenced this issue May 7, 2024
@mikir
[#587] enable warning as errors in msvc
41e9a6e
mikir added a commit that referenced this issue May 9, 2024
@mikir
[#587] Enable warnings as errors in msvc
7b1b0ca 
haha
mikir added a commit that referenced this issue May 10, 2024
@mikir
[#587] Fix all MSVC warnings to enable warnings as errors
18410a2
@mikir mikir self-assigned this May 10, 2024
@mikir mikir closed this as completed May 10, 2024
@mikir mikir changed the title MSVC produces some warnigns in CI builds MSVC produces some warnings in CI builds May 13, 2024
@mikir mikir modified the milestones: 2.15, 2.14.1 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikir mikir

Labels
bug Something isn't working c++ C++ language generator
Projects
None yet
Milestone
2.14.1
Development

No branches or pull requests
2 participants
@Mi-La @mikir