Dangling pointer after move/copy constructor of dynamic bit field arrays

[mikir]

If structure which contains dynamic bit field array is moved or copied, the moved or copied structure still keeps reference to the original structure. This can easily lead to undefined behavior as soon as the original structure is release.

Consider the following schema:

struct DynamicBitFieldArrayStruct
{
    uint8 bitLen;
    bit<bitLen> dynamicBitFieldArray[];
};

and the following test application

int main(int argc, char* argv[])
{
    DynamicBitFieldArrayStruct copy;
    {
        DynamicBitFieldArrayStruct orig(5, {{1, 2, 3, 4, 5 }});
        auto bitBuffer = zserio::serialize(orig);
        std::cout << "orig:" << orig.bitSizeOf() << std::endl;

        copy = orig;

        std::cout << "copy 1:" << orig.bitSizeOf() << std::endl;
    }

    // this copy keeps reference to orig but orig is still in the memory
    std::cout << "copy 2:" << copy.bitSizeOf() << std::endl;

    // overwrite orig
    std::array<uint8_t, 7> arr;
    arr.fill(0xFF);

    // error!
    std::cout << "copy 3:" << copy.bitSizeOf() << std::endl;

    return;
}

Then, the following output can be observed:

orig:41
copy 1:41
copy 2:41
copy 3:1291