Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zserio logo not suitable for dark mode. #500

Closed
MisterGC opened this issue Apr 24, 2023 · 1 comment · Fixed by #499
Closed

zserio logo not suitable for dark mode. #500

MisterGC opened this issue Apr 24, 2023 · 1 comment · Fixed by #499
Assignees
@mikir
Labels
documentation Documentation change is needed enhancement New feature or request
Milestone
2.12

Comments

@MisterGC
Copy link
Contributor

Currently parts of the logo are barely visible when using GitHub dark mode, therefore I suggest to use a logo which works for both light and dark mode.

Current state:
image
@MisterGC MisterGC linked a pull request Apr 24, 2023 that will close this issue
doc: Make logo dark-mode-compatible. #499
Merged
@mikir
Copy link
Contributor

mikir commented Apr 24, 2023

Thanks to figure it out. We will pay attention on that.

@mikir mikir added enhancement New feature or request documentation Documentation change is needed labels Apr 24, 2023
@mikir mikir added this to the 2.11 milestone Apr 24, 2023
@mikir mikir modified the milestones: 2.11, 2.12 May 10, 2023
mikir pushed a commit that referenced this issue May 17, 2023
@MisterGC
doc: Make logo dark-mode-compatible. (#499)
d6de495 
[#500] Change Zserio.png fg color to #322d2d to be dark-mode-compatible
@mikir mikir self-assigned this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikir mikir

Labels
documentation Documentation change is needed enhancement New feature or request
Projects
None yet
Milestone
2.12
Development

Successfully merging a pull request may close this issue.

doc: Make logo dark-mode-compatible. ndsev/zserio
2 participants
@MisterGC @mikir