Bug/duplicate index BELGIUM_MAXIMUM_DEMAND_13_MONTHS #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ejpalacios
commented
Mar 16, 2023
ejpalacios
commented
- Same value returned for month timestamp and occurrence timestamp for BELGIUM_MAXIMUM_DEMAND_13_MONTHS.
- Fluvius meter test case was updated with assertions for all timestamps.
|
LGTM! Thanks for this :) |
|
Thank you for the fix! And thanks @dupondje for reviewing it |
ejpalacios
deleted the
bug/duplicate-index-BELGIUM_MAXIMUM_DEMAND_13_MONTHS
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.