Docs change + Fix some CRT0 symbols #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tpause wasn't included in Makefile and is very basic (also removed from VS references) * trivial.S doesn't actually use gnu-efi and wasn't built * Remove make stuff likely intended for Intel make?? Signed-off-by: Callum Farmer <[email protected]>
* Update guid.c to display correct output code in description * Add warning about failure in ABI README Signed-off-by: Callum Farmer <[email protected]>
* Just to ensure GitHub doesn't run anyway with the hills Signed-off-by: Callum Farmer <[email protected]>
Signed-off-by: Callum Farmer <[email protected]>
* Force code to be at known dest of 4096 * Move _start into .text * Load the _start symbol address and then minus 4096 to get the load address Signed-off-by: Callum Farmer <[email protected]>
* NR_SECTIONS is part of the crt0 generator for fwupd-efi * This isn't implemented here Signed-off-by: Callum Farmer <[email protected]>
* This should use a fully split version of the CRT0 not the old ARM un-split version Signed-off-by: Callum Farmer <[email protected]>
* Local lds wasn't being installed on RISC-V Signed-off-by: Callum Farmer <[email protected]>
gmbr3
added a commit
to gmbr3/fwupd-efi
that referenced
this pull request
Sep 26, 2024
I finally figured out how to best achieve this without breaking GNU ld * Force code to be at known dest of 4096 * Move _start into .text * Load the _start symbol address and then minus 4096 to get the load address This should make the binary more PE32 compatible Change in ncroxon/gnu-efi#45 Signed-off-by: Callum Farmer <[email protected]>
Files have been ending up in differing places between distros - this is an attempt to fix this Signed-off-by: Callum Farmer <[email protected]>
|
@ncroxon Any update? |
|
Sorry for the delay, I was out of the country... |
gmbr3
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've now run through everything ready for a new release (aka 4.0.0) apart from #29
Also I think Private vulnerability reporting needs enabling from the Security tab