Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry for uploading artifact #13

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Add retry for uploading artifact #13

merged 2 commits into from
Mar 5, 2020

Conversation

OpportunityLiu
Copy link

@OpportunityLiu OpportunityLiu commented Mar 4, 2020 •
edited
Loading

Related #12

  • target updated to es2019 since it is fully supported by nodejs12
  • retry 3 times for each artifact with a failure of 5xx
  • add some debug messages, only shown by setting the secret ACTIONS_STEP_DEBUG to true.

@OpportunityLiu OpportunityLiu force-pushed the retry-on-upload-failure branch from 33483fc to 1a7067e Compare March 4, 2020 17:33
@OpportunityLiu OpportunityLiu force-pushed the retry-on-upload-failure branch from 1a7067e to 8850856 Compare March 4, 2020 17:51
@ncipollo
Copy link
Owner

ncipollo commented Mar 4, 2020

Thanks for the pull request! Taking a look now.

ncipollo
ncipollo approved these changes Mar 4, 2020
View reviewed changes
Copy link
Owner

@ncipollo ncipollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things then :shipit:! Thanks again for taking a look at this!

If you are busy I can make the small changes post merge, let me know.

@ncipollo ncipollo merged commit 2ea88b1 into ncipollo:master Mar 5, 2020
@ncipollo
Copy link
Owner

ncipollo commented Mar 5, 2020 •
edited
Loading

Oof, sorry when I squashed and merged it removed you as the author of the commit 😞 . If you would like credit I can add a contributors section to the readme.

@OpportunityLiu OpportunityLiu deleted the retry-on-upload-failure branch March 6, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncipollo ncipollo ncipollo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OpportunityLiu @ncipollo