Clean up logging and fix error handling

ncipollo · Dec 13, 2019 · 734853d · 734853d
1 parent b25a3c6
commit 734853d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/lib/ErrorMessage.js b/lib/ErrorMessage.js
@@ -15,17 +15,21 @@ class ErrorMessage {
             return [];
         }
     }
+    get status() {
+        return this.error.status;
+    }
     hasErrorWithCode(code) {
         return this.githubErrors.some((err) => err.code == code);
     }
     toString() {
         const message = this.error.message;
         const errors = this.githubErrors;
+        const status = this.status;
         if (errors.length > 0) {
-            return `${message}\nErrors:\n${this.errorBulletedList(errors)}`;
+            return `Error ${status}: ${message}\nErrors:\n${this.errorBulletedList(errors)}`;
         }
         else {
-            return message;
+            return `Error ${status}: ${message}`;
         }
     }
     errorBulletedList(errors) {

diff --git a/src/Action.ts b/src/Action.ts
@@ -27,7 +27,7 @@ export class Action {
         if(this.inputs.allowUpdates) {
             try {
                 const getResponse = await this.releases.getByTag(this.inputs.tag)
-                return this.updateRelease(getResponse.data.id)
+                return await this.updateRelease(getResponse.data.id)
             } catch (error) {
                 if (this.noRelease(error)) {
                     return await this.createRelease()
@@ -54,7 +54,7 @@ export class Action {
 
     private noRelease(error:any): boolean {
         const errorMessage = new ErrorMessage(error)
-        return errorMessage.hasErrorWithCode('missing')
+        return errorMessage.status == 404
     }
 
     private async updateRelease(id: number): Promise<string> {

diff --git a/src/ErrorMessage.ts b/src/ErrorMessage.ts
@@ -18,17 +18,22 @@ export class ErrorMessage {
         }
     }
 
+    get status():number {
+        return this.error.status
+    }
+
     hasErrorWithCode(code: String): boolean {
         return this.githubErrors.some((err) => err.code == code)
     }
 
     toString(): string {
         const message = this.error.message
         const errors = this.githubErrors
+        const status = this.status
         if (errors.length > 0) {
-            return `${message}\nErrors:\n${this.errorBulletedList(errors)}`
+            return `Error ${status}: ${message}\nErrors:\n${this.errorBulletedList(errors)}`
         } else {
-            return message
+            return `Error ${status}: ${message}`
         }
     }