Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch spot request failures; don't set root device size unless necessary #86

Merged
merged 2 commits into from
Feb 20, 2016
Merged

Catch spot request failures; don't set root device size unless necessary #86

merged 2 commits into from
Feb 20, 2016

Conversation

nchammas
Copy link
Owner

Spot request failures are now correctly caught and reported on:

$ flintrock launch nick --ec2-instance-type m3.medium --ec2-spot-price 1 --ec2-ami ami-dc6050b6
Requesting 2 spot instances at a max price of $1.0...
0 of 2 instances granted. Waiting...
0 of 2 instances granted. Waiting...
There was a problem with the launch. Cleaning up...
Canceling spot instance requests...
The spot request failed for the following reason: bad-parameters

Additionally, Flintrock does not try to set the root device size to 30GiB unless the default size of the AMI is less than that.

Fixes #83.

nchammas added a commit that referenced this pull request Feb 20, 2016
@nchammas
Merge pull request #86 from nchammas/spot-bad-parameters
97b66d5 
Catch spot request failures; don't set root device size unless necessary
@nchammas nchammas merged commit 97b66d5 into master Feb 20, 2016
@nchammas nchammas deleted the spot-bad-parameters branch February 20, 2016 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nchammas