Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Homebrew install instructions #242

Merged
merged 2 commits into from
Apr 1, 2018
Merged

Conversation

tdsmith
Copy link
Contributor

@tdsmith tdsmith commented Mar 26, 2018

Hi; thanks for flintrock! I packaged flintrock for Homebrew if you'd like to mention it in the readme. The advantage of installing with Homebrew is that it keeps flintrock and its dependencies in its own private virtualenv, and users can get new versions when they run brew upgrade.

@nchammas
Copy link
Owner

Hi @tdsmith and thank you for adding Flintrock to Homebrew. I guess this is where it happened: Homebrew/homebrew-core#25025 👍

I'm not interested in maintaining a Flintrock package for Homebrew at this time, so my concern about adding this to the README is that it "blesses" the Homebrew package as an official installation method. If the Homebrew package is not kept up to date, it will lead to some confusion and I will perhaps get some of the blame.

That said, I wouldn't mind mentioning it in the README as long as it's clear that the Homebrew package is community-maintained and that users wanting to be sure they are getting the latest version should instead stick with pip.

Emphasize that Homebrew support is unofficial
@tdsmith
Copy link
Contributor Author

tdsmith commented Mar 27, 2018

That makes sense! Thanks for your quick feedback. I tried to address your concern by adding a separate section for community-supported distributions; what do you think?

@nchammas
Copy link
Owner

nchammas commented Apr 1, 2018

Looks good to me. I'll merge this in and make some edits for wording.

Thanks again!

@nchammas nchammas merged commit 12d7387 into nchammas:master Apr 1, 2018
@tdsmith tdsmith deleted the patch-1 branch April 1, 2018 00:48
maxpoulain pushed a commit to adotmob/flintrock that referenced this pull request Jan 19, 2021
* Mention Homebrew install instructions

* Add "community-supported distribution" section

Emphasize that Homebrew support is unofficial
maxpoulain pushed a commit to adotmob/flintrock that referenced this pull request Jan 19, 2021
* Mention Homebrew install instructions

* Add "community-supported distribution" section

Emphasize that Homebrew support is unofficial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants