Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add modal view component #225

Closed
wants to merge 46 commits into from
Closed

Feature: Add modal view component #225

wants to merge 46 commits into from

Conversation

syphax-bouazzouni
Copy link
Contributor

Prerequisite

What and why

Todo

Usage

Todo

Changes/TODOs

  • Create a view component for showing modal (using bootstrap modal)

Re-use the view component where we used bootstrap modal

  • create new mappings
  • ... (todo list the other places)

Replace the usage of jquery facebox with this view component

  • show ontology mappings details
  • show notes thread
  • ... (todo list the other places)

@syphax-bouazzouni
rails app:update changes
278cd0c
@syphax-bouazzouni
fix the rails zeitwerk:check warnings
c776c53
@syphax-bouazzouni
rails 7 app:update changes
a7132a9
@syphax-bouazzouni
update rails config load_defaults to 7.0
c5d286b
@syphax-bouazzouni
update db schema to version 7.0
99c42ae
@syphax-bouazzouni
install jsbundling-rails
1f56d3c
@syphax-bouazzouni
import and install stimulus
e7002ec
@syphax-bouazzouni
add to Gemfile the new gems of Rails 7
6cc4604
@syphax-bouazzouni
add the asset pipeline entry points manifest
98d133c
@syphax-bouazzouni
add the esbuild bundle to the application asset pipeline
6c1d365
@syphax-bouazzouni
use the new Rails 7 js compressor (terser)
87e809e
@syphax-bouazzouni
use the new Rails 7 sass compiler
a36924c
@syphax-bouazzouni
remove useless precompile additional assets already added by default
452e736
@syphax-bouazzouni
enable assets.debug in development environment
82ed032
@syphax-bouazzouni
remove and replace sass ruby script functions because did not work
ada92ff
@syphax-bouazzouni
enable turbo-rails but disable by default turbo-drive
1e84464
@syphax-bouazzouni
replace bp_ontology_viewer.js with turbo frame in the ontology viewer
9371bc4
@syphax-bouazzouni
fix visits chart not showing
f73f7fc
@syphax-bouazzouni
fix more... submission button not working
4e06e29
@syphax-bouazzouni
fix notes js
0987e08
@syphax-bouazzouni
fix notes unsubscribe button
d21c570
@syphax-bouazzouni
fix mappings facebox links
b07647a
@syphax-bouazzouni
fix classes tree node click
8daa8f0
@syphax-bouazzouni
fix classes jump to init
0674ce2
@syphax-bouazzouni
fix properties tab init
92a2060
@syphax-bouazzouni
add concept show endpoint
9c7d3a2
@syphax-bouazzouni
replace tree view node click js code with turbo_frames
412bd3f
@syphax-bouazzouni
update and centralize Split dependancy and usage
a8e029b
@syphax-bouazzouni
replace tree view display js with a turbo_frame and stimulus controller
675c4f3
@syphax-bouazzouni
exctract autocomplete behavior in a stimulus controller
ecfa8ca
@syphax-bouazzouni
replace concept tabs js code to bootstrap navs
6910d78
@syphax-bouazzouni
fix notes link_button href
8005da0
@syphax-bouazzouni
add card style to the visualize partial
7e32997
@syphax-bouazzouni
center the loader
565e5c4
@syphax-bouazzouni
remove HelloController and unused dependencies in package.json
bee5d70
@syphax-bouazzouni
add view component gem
fde69e0
@syphax-bouazzouni
configure view components
d3351a0
@syphax-bouazzouni
update mappings from style
64e6ee9
@syphax-bouazzouni
replace mappings show from rendering js to html
b41eb85
@syphax-bouazzouni
add show_modal controller using bootstrap modal
25922c2
@syphax-bouazzouni
add turbo modal controller to hide modal and remove content
0717542
@syphax-bouazzouni
add turbo_modal view component
7d43e2d
@syphax-bouazzouni
remplace old modal for creating a new mapping with the modal component
18b8e66
@syphax-bouazzouni
remove unused js code in bp_create_mappings
5e73cee
@syphax-bouazzouni
remove forgotten import
b5f690e
@syphax-bouazzouni
Merge branch 'pr/refactor/ontology-viewer-replace-js-with-hotwire' in…
31e9a89 
…to pr/feature/add-modal-view-component
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Sep 23, 2022
Closed
4 tasks
@syphax-bouazzouni syphax-bouazzouni changed the title Add modal view component Feature: Add modal view component Sep 23, 2022
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Oct 4, 2022
Closed
11 tasks
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Dec 19, 2022
Closed
57 tasks
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Dec 28, 2022
Closed
67 tasks
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Jan 31, 2023
Merged
@jvendetti jvendetti closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syphax-bouazzouni @jvendetti