Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): add github-cli to distrib image #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bucherfa
Copy link

@bucherfa bucherfa commented Jan 8, 2025

Hi :)
really like this project.

Not sure if this is something you would like to include, but I would love to have the Github CLI available within the docker image.

@ncarlier
Copy link
Owner

Hi, thanks for your interest. I'd like to add a lot of useful tools in the distribution image but the image size can become a problem and regarding github-cli, it's a Go binary so a bit heavy (20Mb). What I usually do with Webhookd is to add a pre-installation section to my script.

For instance:

#!/bin/bash

# Functions
assert_mc_is_installed() {
  if ! command -v mc &> /dev/null
  then
    echo "installing mc..."
    wget https://dl.min.io/client/mc/release/linux-amd64/mc -P /usr/local/bin
    chmod +x /usr/local/bin/mc
  fi
}

assert_mc_is_installed

# cool stuff with mc...

Of course, if more people are interested by githuh-cli I'll add it. I leave the MR as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants