Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

body-soft-max-line-length exception #124

Closed
knocte opened this issue Jul 12, 2023 · 2 comments · Fixed by #133
Closed

body-soft-max-line-length exception #124

knocte opened this issue Jul 12, 2023 · 2 comments · Fixed by #133

Comments

@knocte
Copy link
Member

knocte commented Jul 12, 2023 •
edited
Loading

This rule should not break the build if the offending line exceeds 64 chars because it uses a commit hash at the end.

Testcase:

GrpcService: fix some logging nits

These mistakes were made in 45faeca2f0e7c9c5545f54fb3fcc815f52b8a7cf.

Testcase that should still break the build (because line is longer than 64 chars before the commit hash):

GrpcService: fix some logging nits

These mistakes were made in this GrpcService's RunIntoMeService commit: 45faeca2f0e7c9c5545f54fb3fcc815f52b8a7cf.
@tehraninasab
Copy link
Contributor

@webwarrior-ws please work on this issue if you are taskless.

webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Jul 17, 2023
@webwarrior-ws
commitlint(plugins.test): add tests for issue#124
f32fa77 
Add tests that cover cases described in nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Jul 17, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
aeed168 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.
Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Jul 17, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
2ba7d85 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.
Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Jul 17, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
06b3102 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.
Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Jul 18, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
eea3ae8 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.
Fixes nblockchain#124.
@knocte
Copy link
Member Author

knocte commented Aug 1, 2023

@realmarv I think @webwarrior-ws got stuck with this task, I don't remember his reasoning. Please pair with him on it after he's done with his NLitecoin low-prio task.

tehraninasab pushed a commit to tehraninasab/conventions that referenced this issue Aug 1, 2023
@webwarrior-ws @tehraninasab
commitlint(plugins.test): add tests for issue#124
4c1dc50 
Add tests that cover cases described in nblockchain#124.
tehraninasab pushed a commit to tehraninasab/conventions that referenced this issue Aug 1, 2023
@webwarrior-ws @tehraninasab
commitlint(plugins): fix issue#124
142a2fb 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.
Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 1, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
9cb9a70 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.
Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 1, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
89d8d0f 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.

Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 1, 2023
@webwarrior-ws
commitlint(plugins.test): add tests for issue#124
90263db 
Add tests that cover cases described in nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 1, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
bd95a0b 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.

Fixes nblockchain#124.
@webwarrior-ws webwarrior-ws mentioned this issue Aug 1, 2023
Merged
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 1, 2023
@webwarrior-ws
commitlint(plugins.test): add tests for issue#124
8689cda 
Add tests that cover cases described in [1].

[1] nblockchain#124
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 1, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
0f8f229 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.

Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 2, 2023
@webwarrior-ws
commitlint(plugins.test): add tests for issue#124
a8e8ea6 
Add tests that cover cases described in [1]. This commit has
failing test.

[1] nblockchain#124
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 2, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
b21edbf 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.

Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 2, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
a4f39f1 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.

Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 2, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
432ae63 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.

Fixes nblockchain#124.
webwarrior-ws added a commit to webwarrior-ws/conventions that referenced this issue Aug 2, 2023
@webwarrior-ws
commitlint(plugins): fix issue#124
8e4b640 
Add exception to bodySoftMaxLineLength when line exceeds max
length but ends with a git commit hash.

Fixes nblockchain#124.
knocte added a commit that referenced this issue Aug 2, 2023
@knocte
Merge PR #133 from webwarrior-ws/body-max-line-length-exception
b2965b5 
Fixes #124
parhamsaremi pushed a commit to parhamsaremi/conventions that referenced this issue Aug 3, 2023
@knocte @parhamsaremi
Merge PR nblockchain#133 from webwarrior-ws/body-max-line-length-exce…
4597044 
…ption

Fixes nblockchain#124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Body soft max line length exception webwarrior-ws/conventions
2 participants
@knocte @tehraninasab