Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize plugin size #498

Closed
paul-dingemans opened this issue Apr 7, 2024 · 0 comments · Fixed by #501
Closed

Minimize plugin size #498

paul-dingemans opened this issue Apr 7, 2024 · 0 comments · Fixed by #501
Milestone

Comments

@paul-dingemans
Copy link
Collaborator

Current implementation of #487 results in increasing the size of the plugin with 64 MB for each version of the ktlint rules being added. Plugin would grow from almost 60MB (version 0.21.0) to +374MB with 5 different ktlint rulesets included.

@paul-dingemans paul-dingemans added this to the 0.23.0 milestone Apr 7, 2024
paul-dingemans added a commit that referenced this issue Apr 10, 2024
When creating a shadow jar of a specific ktlint ruleset all transitive dependencies are included in that jar. Combining the individual ruleset shadow jars in the plugin-jar blows up the size of the plugin jar as the same dependencies are included multiple times. By first combining the ruleset shadow jars into another shadowed jar the duplicate dependencies are pruned.

Closes #498
paul-dingemans added a commit that referenced this issue Apr 10, 2024
When creating a shadow jar of a specific ktlint ruleset all transitive dependencies are included in that jar. Combining the individual ruleset shadow jars in the plugin-jar blows up the size of the plugin jar as the same dependencies are included multiple times. By first combining the ruleset shadow jars into another shadowed jar the duplicate dependencies are pruned.

Closes #498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant