-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bare en sakid #6878
Bare en sakid #6878
Conversation
import java.math.BigDecimal | ||
import java.time.YearMonth | ||
|
||
data class KravgrunnlagId( | ||
val value: Long, | ||
) | ||
|
||
data class SakId( | ||
val value: Long, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Denne er litt skummel, mener jeg så i en eller annen sammenheng at disse blir lagret ned med value
i databasen siden de ikke er annotert med @JsonValue. Det betyr at gamle tilbakekrevinger vil slite med denne endringen. Da må eksisterende data migreres i alle fall. Forøvrig enig at det er greit å holde seg til en type på disse tingene.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan heller se på å endre common SakId.sakId
til SakId.value
?
gen.writeObjectFieldStart("sakId") | ||
gen.writeObjectField("value", value.sakId.sakId) | ||
gen.writeEndObject() | ||
gen.writeObjectField("sakId", value.sakId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slik ble den serialisert tidligere
{"sakId":{"value":1},"sakType":"BARNEPENSJON","fnr":{"value":"123456"},"utbetalingslinjer":[]}
Sånn blir den serialisert nå:
{"sakId":1,"sakType":"BARNEPENSJON","fnr":{"value":"123456"},"utbetalingslinjer":[]}
1312c06
to
06cdc05
Compare
06cdc05
to
6ba2532
Compare
No description provided.