Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare en sakid #6878

Closed
wants to merge 3 commits into from
Closed

Bare en sakid #6878

wants to merge 3 commits into from

Conversation

sebassonav
Copy link
Contributor

No description provided.

import java.math.BigDecimal
import java.time.YearMonth

data class KravgrunnlagId(
val value: Long,
)

data class SakId(
val value: Long,
Copy link
Contributor

@henrikg henrikg Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denne er litt skummel, mener jeg så i en eller annen sammenheng at disse blir lagret ned med value i databasen siden de ikke er annotert med @JsonValue. Det betyr at gamle tilbakekrevinger vil slite med denne endringen. Da må eksisterende data migreres i alle fall. Forøvrig enig at det er greit å holde seg til en type på disse tingene.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan heller se på å endre common SakId.sakId til SakId.value?

@sebassonav sebassonav requested a review from henrikg January 28, 2025 15:19
gen.writeObjectFieldStart("sakId")
gen.writeObjectField("value", value.sakId.sakId)
gen.writeEndObject()
gen.writeObjectField("sakId", value.sakId)
Copy link
Contributor Author

@sebassonav sebassonav Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slik ble den serialisert tidligere
{"sakId":{"value":1},"sakType":"BARNEPENSJON","fnr":{"value":"123456"},"utbetalingslinjer":[]}
Sånn blir den serialisert nå:
{"sakId":1,"sakType":"BARNEPENSJON","fnr":{"value":"123456"},"utbetalingslinjer":[]}

@sebassonav sebassonav force-pushed the feature/bare-en-sakid branch from 1312c06 to 06cdc05 Compare January 28, 2025 15:41
@sebassonav sebassonav force-pushed the feature/bare-en-sakid branch from 06cdc05 to 6ba2532 Compare January 28, 2025 15:42
@sebassonav sebassonav closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants