EY-4753 Sette høyeste gradering basert på 3-parter ved opprett behand… #6861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebassonav
commented
Jan 24, 2025
|
|
||
| if (identerMedGradering.any { it.erGradert() }) { | ||
| val hoyesteGradering = identerMedGradering.hentPrioritertGradering() | ||
| sakService.oppdaterAdressebeskyttelse(sakId, hoyesteGradering) |
There was a problem hiding this comment.
Denne trenger strengt talt kanskje ikke å være med her da en person med strengt_fortrolig/utland får alle familiemedlemmer markert, men siden det nok ikke gjøres for fortrolig er det nok greit å få med.
There was a problem hiding this comment.
Jeg tenker det er bra å være konsekvent og det virker tryggest.
oyvindsh
reviewed
Jan 24, 2025
| import no.nav.etterlatte.sak.PersonManglerSak | ||
| import no.nav.etterlatte.sak.SakService | ||
|
|
||
| class TilgangsServiceOppdaterer( |
There was a problem hiding this comment.
OppdaterTilgangService? ikke noe big deal
oyvindsh
reviewed
Jan 24, 2025
|
|
||
| val identerMedGradering = alleIdenter.map { hentGraderingForIdent(it, sak) } | ||
|
|
||
| if (identerMedGradering.any { it.erGradert() }) { |
There was a problem hiding this comment.
Kunne denne evt. vært navngitt med adressebeskyttelse i metode f.eks. så det er lettere å koble det til kun adressebeskyttelse når man leser?
oyvindsh
approved these changes
Jan 24, 2025
sebassonav
deleted the
feature/EY-4753-skjerme-hvis-relatert-person-eregenansatt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ling.
Mangler 2 deler, der 1/2 er å gjøre det på hendelser som kommer inn og 3 er å vurdere å gjøre det på eksisterende saker/one time job